Repository navigation
🧪 test: Wait for the Reply Tab's Seen Write Before Restoring the Unread Baseline - #17870
Merged
Merged
Conversation
… Baseline The withheld-reply scenario restored the unread baseline in Mongo right after the reply tab finished, while that tab was still posting its own seen acknowledgement. When the acknowledgement landed second it overwrote the baseline, the first tab polled a conversation the server considered read, and its dot never appeared. The sibling scenario already waits for the acknowledgement; this one now does too.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
unseen-replies.spec.ts:486(withheld-replies-released-after-grant) failed about half of its runs on dev, and reddened unrelated PRs at random. The scenario sends a reply from a second tab, then restores the unread baseline in Mongo so the first tab's away poll can light the dot. The second tab is focused and acknowledges the reply it just rendered withPOST /api/convos/seen, and that write sometimes landed after the restore and overwrote it. The first tab then polled a conversation the server considered read, so the dot could never appear and the 45 second wait timed out.The sibling scenario
reply-finishing-in-another-tab-lights-dotalready waits for that acknowledgement before restoring the baseline. This scenario now does the same. Only the test changes; a reply seen in a focused tab is correctly marked seen.Type of change
Testing
Automated tests:
--repeat-each=12 --retries=0, 12 passed.lastSeenAtnewer thanlastResponseAt, right after the second tab's seen write.Screenshots / recordings
No user-facing change.
Risk / compatibility
None: a test-only change.
Checklist